refactor: replace algosdk with algokit-utils#108
Open
aorumbayev wants to merge 3 commits intomainfrom
Open
Conversation
Remove algosdk dependency and use @algorandfoundation/algokit-utils instead. - Import types and utilities from algokit-utils subpaths - Use decodeSimulateResponseFromJson for trace parsing - Compute LogicSig address using hash and encodeAddress utilities
aorumbayev
force-pushed
the
decoupling
branch
from
9b3f8dc to
dc938d7
Compare
joe-p
approved these changes
Mar 23, 2026
joe-p
left a comment
joe-p
left a comment
There was a problem hiding this comment.
Question about Lsig address but otherwise LGTM
| lsigBytes = new Uint8Array(Buffer.from(lsigBytes, 'base64')) | ||
| } | ||
| const lsigAddr = lsigBytes ? new algosdk.LogicSigAccount(lsigBytes).address() : undefined | ||
| const lsigAddr = lsigBytes ? computeLogicSigAddress(lsigBytes) : undefined |
There was a problem hiding this comment.
Is there a reason for using this function vs new LogicSig(lsigBytes).address()?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
algosdkdependency with@algorandfoundation/algokit-utilsdecodeSimulateResponseFromJsoninstead of custom recursive parsingalgokit-utilsutilitiescomputeLogicSigAddressfunction for Logic Sig address calculationappCall.appId→applicationCall.appIndex)algosdkparsing code and update related testsNOTES